patternfly / patternfly-org

Home of patternfly.org
https://www.patternfly.org
MIT License
69 stars 135 forks source link

Switch design guidelines need updating #4121

Open thatblindgeye opened 1 week ago

thatblindgeye commented 1 week ago

Is this a new page or a change to an existing one? The design guidelines for Switch look to be either quite outdated and/or incorrect. Images reference 2 labels being used with a Switch, one "form label" and a "switch label". Right now for v5 there's only ever 1 label for a Switch, and in v6 we're updating the API to discourage/prevent dynamic labeling for "on" and "off" states.

This should definitely be done for v6 (we need to also add a11y docs in v6 so whomever would want to work on the design guidelines I could pair up with to have parity between the 2). A v5 update would eb great as well, though may be slightly different due to the API still allowing dynamic labeling.

Describe the enhancement

Are there visuals for this enhancement? If applicable, please include examples for each state and for varying widths Include screenshots or links to Marvel or other mockups.

Any other information?