search

patternfly / patternfly-org

Home of patternfly.org
https://www.patternfly.org
MIT License
69 stars 136 forks source link

fix: update styles on color page #4157

Closed nicolethoen closed 1 month ago

nicolethoen commented 1 month ago

Closes https://github.com/patternfly/patternfly-org/issues/4067 Closes https://github.com/patternfly/patternfly-org/issues/4073

patternfly-build commented 1 month ago

Preview: https://patternfly-org-pr-4157-site.surge.sh

edonehoo commented 1 month ago

A few things I noticed:

  1. In dark mode, the text on the color families doesn't update and can't be read in some cases:

    image

  2. Also in the families, there are sometimes no tokens listed (which maybe there are just no tokens related to the color? but it looks like there should be some listed):

    image

  3. Related to ^ Should we change the label from "CSS variables" to "Tokens" in the expanded family sections?

  4. This is small, but the primary background color swatch has a background, even before you hover:

    image
nicolethoen commented 1 month ago

4. This is small, but the primary background color swatch has a background, even before you hover:

That's because without a background color, the color swatch is invisible! 😆 I'm open to other color suggestions!

Also in the families, there are sometimes no tokens listed (which maybe there are just no tokens related to the color? but it looks like there should be some listed):

I can make a 'no semantic tokens message if there are none?

edonehoo commented 1 month ago

That's because without a background color, the color swatch is invisible!

Oh, duh! 😆 I can't think of a different approach that's ~the golden ticket, so I think we can just stick with this one, just to get the info updated? And then maybe revisit with a designer to see if we want to change it