search

patternfly / patternfly-org

Home of patternfly.org
https://www.patternfly.org
MIT License
69 stars 136 forks source link

fix(docs): removed extra link tags in card title #4166

Closed evwilkin closed 3 weeks ago

evwilkin commented 1 month ago

Closes #4165

Depends on https://github.com/patternfly/patternfly/pull/6949 & React follow up - will require version bump with those changes.

This PR removes extra <a> tags in the actionable cards on the docs homepage which are causing link styling to be applied - these tags are not needed.

patternfly-build commented 1 month ago

Preview: https://patternfly-org-pr-4166-site.surge.sh

evwilkin commented 1 month ago

@nicolethoen thanks for the catch - it looks like this is happening with the Actionable cards example too, where you tab into the Cards and navigate between them with arrow keys but moving to a card with a link immediately triggers the link - does this look like a React bug?

We can close this PR out or let it sit for now if this is a larger issue that would need to be fixed in React 👀

@tlabaj FYI