fix(docs): tokenize footer styles

patternfly / patternfly-org

Home of patternfly.org

https://www.patternfly.org

MIT License

69 stars 136 forks source link

fix(docs): tokenize footer styles #4167

Closed evwilkin closed 2 weeks ago

evwilkin commented 1 month ago

Closes #4061

This PR:

Replaces custom styles in footer.js with tokens, or removes custom styles completely where possible
Fixes GDPR banner functionality (currently it always shows, is not dismissable)

patternfly-build commented 1 month ago

Preview: https://patternfly-org-pr-4167-site.surge.sh

Updated preview: https://pf-org-pr-4167-site.surge.sh (Original link doesn't seem to be working)

evwilkin commented 3 weeks ago

Thanks @bekah-stephens your feedback was super helpful to get this corrected, hopefully everything matches what you suggested now!

evwilkin commented 2 weeks ago

Clarity to semibold note above from offline conversation:

since we're suggesting that we use red hat text which is our body font family, we should be using global--font--weight--body--bold there! it maps to font--weight--200 base token, which is 500 (technically a "medium" in the red hat text)

evwilkin commented 2 weeks ago

Thanks @bekah-stephens & @lboehling - updated now with those changes 👍