search

patternfly / patternfly-org

Home of patternfly.org
https://www.patternfly.org
MIT License
69 stars 136 forks source link

fix(docs): switched from v4 to evergreen badge link #4186

Closed rebeccaalpert closed 3 weeks ago

rebeccaalpert commented 4 weeks ago

Fixes https://github.com/patternfly/patternfly-org/issues/4124.

patternfly-build commented 4 weeks ago

Preview: https://patternfly-org-pr-4186-site.surge.sh

rebeccaalpert commented 4 weeks ago

LGTM. A little scope-creep but there is another link on this page that isn't absolute and doesn't take you to the correct page. Just needs a leading /

https://github.com/patternfly/patternfly-org/blob/65975ec5c0857f722a6a422e4cb27c2e8c901520/packages/documentation-site/patternfly-docs/content/design-guidelines/components/label/label.md?plain=1#L159

I wonder if we should try to dig up more of those?

Sure! Added a leading backslash and fixed the typo there. I haven't looked for more links without slashes, but I am seeing more v4 links than just this. I did a search for v4 in ./packages/documentation-site/patternfly-docs/content/design-guidelines and saw some other hits.

rebeccaalpert commented 4 weeks ago

No worries! Should be all set: https://patternfly-org-pr-4186-site.surge.sh/components/label/design-guidelines