support all admonitions, concat description blocks

patternfly / patternfly-quickstarts

Repository containing the PatternFly Quick Start extension code

MIT License

15 stars 38 forks source link

support all admonitions, concat description blocks #117

Closed CooperRedhat closed 2 years ago

CooperRedhat commented 2 years ago

Closes #105

Also solves issue where only the final newline separated string (or .adoc block) was rendered in description.

netlify[bot] commented 2 years ago

✔️ Deploy Preview for quickstarts ready!

🔨 Explore the source changes: b17998a65cb84654dfd3f04eaf1f0d83fc7ed0a5

🔍 Inspect the deploy log: https://app.netlify.com/sites/quickstarts/deploys/61f1993cd2d6840007ae2199

😎 Browse the preview: https://deploy-preview-117--quickstarts.netlify.app/

jschuler commented 2 years ago

Can we map these to different alert icons/colors? Btw here's some info on the admonition types for other's who may want to weigh in https://docs.asciidoctor.org/asciidoc/latest/blocks/admonitions/ Screen Shot 2022-01-24 at 3 08 17 PM

jschuler commented 2 years ago

Possible way we could map the IMPORTANT|CAUTION|WARNING admonitions to the PatternFly alert variants: Screen Shot 2022-01-24 at 3 19 47 PM

CooperRedhat commented 2 years ago

3 alert types are now mapped and rendered to Asciidoc admonition types. I left the note and tip sections the same, some additional input on how to differentiate those would be appreciated.