patternfly / patternfly-quickstarts

Repository containing the PatternFly Quick Start extension code
MIT License
15 stars 39 forks source link

Dark theme #141

Closed srambach closed 2 years ago

srambach commented 2 years ago

Closes #82 Adds a dark theme and switch based on Patternfly's dark theme. Initial set up by @DaoDaoNoCode.

netlify[bot] commented 2 years ago

Deploy Preview for quickstarts ready!

Name Link
Latest commit c1207af98cb0eb33f94a54ff0ce06e2cbeda3579
Latest deploy log https://app.netlify.com/sites/quickstarts/deploys/6245b62562db530008929038
Deploy Preview https://deploy-preview-141--quickstarts.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

DaoDaoNoCode commented 2 years ago

Is there a style for the inline <code> tag? Currently, I can only tell the difference from the font, is there a background color for it in the dark mode?

Screen Shot 2022-03-04 at 2 08 04 PM Screen Shot 2022-03-04 at 2 08 48 PM
lboehling commented 2 years ago

The dark theme looks great overall! I reviewed with Michael and we saw a few small visual tweaks to make.

In the drawer:

In the catalog:

thanks!

srambach commented 2 years ago
  • The text before the tasks (“In this quick start, you will complete X tasks”) should be using our secondary text color, which is pf-black-200 in dark theme. (This may need to be updated in the default qs drawer too).

This one doesn't have a unique identifier, so it will need something to identify it in order to style it.

This is a bigger change and should probably be a separate PR.

@lboehling, I think I got the rest!

lboehling commented 2 years ago

Looks great! Thank you @srambach!

srambach commented 2 years ago

Added issue #155 to fix the card hover state.

CooperRedhat commented 2 years ago

LGTM