Closed srambach closed 2 years ago
Name | Link |
---|---|
Latest commit | c1207af98cb0eb33f94a54ff0ce06e2cbeda3579 |
Latest deploy log | https://app.netlify.com/sites/quickstarts/deploys/6245b62562db530008929038 |
Deploy Preview | https://deploy-preview-141--quickstarts.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Is there a style for the inline <code>
tag? Currently, I can only tell the difference from the font, is there a background color for it in the dark mode?
The dark theme looks great overall! I reviewed with Michael and we saw a few small visual tweaks to make.
In the drawer:
In the catalog:
thanks!
- The text before the tasks (“In this quick start, you will complete X tasks”) should be using our secondary text color, which is pf-black-200 in dark theme. (This may need to be updated in the default qs drawer too).
This one doesn't have a unique identifier, so it will need something to identify it in order to style it.
- the cards lose their hover states in dark theme--This would be resolved if we updated the quickstarts catalog cards to use our new selectable cards state styling https://www.patternfly.org/v4/components/card#selectable
This is a bigger change and should probably be a separate PR.
@lboehling, I think I got the rest!
Looks great! Thank you @srambach!
Added issue #155 to fix the card hover state.
LGTM
Closes #82 Adds a dark theme and switch based on Patternfly's dark theme. Initial set up by @DaoDaoNoCode.