patternfly / patternfly-quickstarts

Repository containing the PatternFly Quick Start extension code
MIT License
15 stars 38 forks source link

[Quick Start] - [Need a Way to Inform Important Messages ] #160

Closed heyethankim closed 2 years ago

heyethankim commented 2 years ago

Is this a new component or an extension of an existing one? We should be able to use the Alert component within the Quick Start. https://www.patternfly.org/v4/components/alert

Describe the feature Sometimes a Quick Start is associated with the technical preview. Some of the features should be taken seriously, for example, Feature Gate. Because once it is turned on, there is no turning back. Customers should be aware that they shouldn't do this on the production cluster. So this message should be communicated in a clear way.

Are there visuals for this feature? If applicable, please include examples for each state and for varying widths Again we can use the Alert component. https://www.patternfly.org/v4/components/alert

Any other information?

KevinFCormier commented 2 years ago

@andybraren mentioned that this was already implemented via https://github.com/patternfly/patternfly-quickstarts/issues/16

You can see an example of using an "admonition" here: https://github.com/patternfly/patternfly-quickstarts/blob/main/packages/dev/src/quickstarts-data/yaml/template.yaml#L82

I tried this in OpenShift, but it was not recognized. CC @spadgett

CooperRedhat commented 2 years ago

Sorry for the delay here. It looks like Openshift is a few versions behind: https://github.com/openshift/console/blob/master/frontend/package.json#L130

image Rendered here: https://quickstarts.netlify.app/?quickstart=getting-started-with-quick-starts

Let us know if you run into any more issues.

heyethankim commented 2 years ago

Wow, this is fantastic. Thanks @CooperRedhat

CooperRedhat commented 2 years ago

Closing as this seems to be resolved.