patternfly / patternfly-quickstarts

Repository containing the PatternFly Quick Start extension code
MIT License
15 stars 38 forks source link

Quick start conclusion doesn't display multiple paragraphs #163

Closed bhardesty closed 2 years ago

bhardesty commented 2 years ago

In the Getting started with Red Hat OpenShift Streams for Apache Kafka quick start, the conclusion only displays the first paragraph of text:

image

However, the quick start source shows that there is a second paragraph that doesn't get displayed:

ifdef::qs[]
[#conclusion]
Congratulations! You successfully completed the {product-kafka} Getting Started quick start, and are now ready to use the service.

You can use Kafka scripts to check that you can connect with your Kafka instance.
endif::[]

Source for the quick start: https://github.com/redhat-developer/app-services-guides/blob/main/docs/kafka/getting-started-kafka/README.adoc

CooperRedhat commented 2 years ago

This has to do with how asciidoc parses the content. An empty line indicates to the parser that a new block has been started, therefore it no longer belongs to the [#conclusion] block.

Here is the documentation on how to have empty breaks in a multi paragraph block: https://docs.asciidoctor.org/asciidoc/latest/blocks/delimited/#linewise-delimiters

And another example that I got working locally:

ifdef::qs[]
[#conclusion]
--
Congratulations! You successfully completed the {registry} Getting Started quick start, and are now ready to use the service.

You can use Kafka scripts to check that you can connect with your Kafka instance.
--
endif::[]

image

If that doesn't work feel free to reopen the issue and I can look into it further.