search

patternfly / patternfly-quickstarts

Repository containing the PatternFly Quick Start extension code
MIT License
15 stars 38 forks source link

Filter fix #237

Closed radekkaluzik closed 6 months ago

radekkaluzik commented 1 year ago

Reason for this fix: https://issues.redhat.com/browse/RHCLOUD-25108

There is a workaround in place: https://github.com/RedHatInsights/learning-resources/pull/12/files

There is a breaking change in the latest version of PatternFly (this is why I have added "@patternfly/react-core" to dependencies). SearchInput onChange method expects event as its first argument and then the actual string.

netlify[bot] commented 1 year ago

Deploy Preview for quickstarts ready!

Name Link
Latest commit 34d228165ba637d799af63b179d3595a2554e808
Latest deploy log https://app.netlify.com/sites/quickstarts/deploys/6463848f8c7c10000856d351
Deploy Preview https://deploy-preview-237--quickstarts.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

vikram-raj commented 1 year ago

We are facing this issue in the Openshift console quick starts https://issues.redhat.com/browse/OCPBUGS-13359.

When will this get in?

dgutride commented 1 year ago

hi - we requested changes on this PR - I haven't seen an update to this but we can certainly prioritize closing this and fixing this a different way.