Closed karelhala closed 5 months ago
Name | Link |
---|---|
Latest commit | 7956278f9243b037dfbd2c0a00d947472bb3b354 |
Latest deploy log | https://app.netlify.com/sites/quickstarts/deploys/65de0ac3e418d00008c95d19 |
Deploy Preview | https://deploy-preview-283--quickstarts.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@dlabaj thank you! I might need some help with the duplicate IDs, they look like are not par of my changes. However I had to change how ID is generated for tile, it used to take just name. Now it consumes ID as well and if that is present it uses this ID. I then changed how quickstart is activated and use just the name of quickstart (as ID can be different than name).
Okay - i've discovered that the duplicate id in these docs is description-alert-note
I'm about to try and fix it, but if knowing that means someone knows the quick fix, then let me know.
CustomCatalog is looping over the same list twice of allQuickStarts
to build the Bookmarkable and the Instructional lists of Quickstart tiles.
the hardcoded id
on line 8 of alert-note-prereq/README.adoc
is what is being used twice in the docs
@nicolethoen yeah I wanted to duplicate the quickstarts as an example of bookmarked items. I am starting to think about removing the custom catalog changes and let PF team to do proper examples :disappointed:
@karelhala We decided to remove the asciidoc examples. The only product that uses it was kafka but that product is no longer available. While the feature to use the asciidoc is still there we are going to encourage people to use markdown instead.
This issue is causing the Percy test to fail. https://github.com/patternfly/patternfly/issues/6352. We will need a fix from core. It only affects chrome and works in firefox. I wouldn't hold up this merge to quickstart over the failing Percy test. Let me know what you think @jessiehuff @nicolethoen
:tada: This PR is included in version 5.2.0-prerelease.3 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Description
In our quickstarts we need to render a bookmark button that bookmarks the quickstart. In order to render said button we need to send a button with this icon to the quickstart. This PR surfaces this trough quickStartTile to the header.
Screenshot