search

patternfly / patternfly-quickstarts

Repository containing the PatternFly Quick Start extension code
MIT License
15 stars 38 forks source link

Allow disabling quickstart panel grabbing focus #300

Closed randomnetcat closed 2 months ago

randomnetcat commented 2 months ago

I'm working on an application that provides a UI for people making QuickStart files. As part of this, I'm trying to use QuickStartDrawer to render a preview of the QuickStart. However, if the QuickStart is a QuickStart with tasks, thus opening the side panel, whenever the values in the QuickStart are changed, the panel grabs focus.

For instance, if I have a textbox that allows editing the description of a QuickStart, the user will enter a character into the textbox. That will result in the QuickStart being changed in the QuickStartContext. This will propagate down to QuickStartPanel and trigger this hook and pull focus to the panel, away from the textbox the user was editing.

To allow working around this, I am proposing to allow disabling everything that pulls focus to the panel with a new value in QuickStartContext. This value defaults to the status quo to preserve backwards-compatibility.

netlify[bot] commented 2 months ago

Deploy Preview for quickstarts ready!

Name Link
Latest commit bf4ea4e4b65033ea7a721e09a50c1508e95b185e
Latest deploy log https://app.netlify.com/sites/quickstarts/deploys/6669f26b69f1ce000806d7df
Deploy Preview https://deploy-preview-300--quickstarts.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 5.4.0-prerelease.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: