patternfly / patternfly-quickstarts

Repository containing the PatternFly Quick Start extension code
MIT License
15 stars 38 forks source link

Update styling for v6 #303

Closed jessiehuff closed 3 weeks ago

jessiehuff commented 2 months ago

Closes https://github.com/patternfly/patternfly-quickstarts/issues/299

preview docs: https://qs-design-update-docs.surge.sh/extensions/quick-starts preview demo: https://qs-design-update.surge.sh/

andrew-ronaldson commented 1 month ago

Not sure if there have been conversations about this yet but we have a blue header in Figma for the drawer. Screenshot 2024-07-05 at 9 05 07 AM

nicolethoen commented 1 month ago

@andrew-ronaldson I don't think it's made it to core/react yet. I can link to any issues that get created in a quickstarts follow up issue to make sure we use it once it exists.

andrew-ronaldson commented 1 month ago

Could we make this drawer header in quickstarts using tokens if I put it together?

nicolethoen commented 1 month ago

@andrew-ronaldson I took a stab at identifying appropriate tokens to get it running. I updated the preview links at the top of this PR. LMK what you think! :)

andrew-ronaldson commented 1 month ago

Looks good but we'll need a follow up issue for some bugs. Adding here but I'll put them in another issue if they can't be addressed for Beta. @lboehling do you have any other thoughts on this?

The cards don't seem to have a hover or clicked state applied. Screenshot 2024-07-17 at 10 41 10 AM

The quickstart header needs a bit more padding, please Screenshot 2024-07-17 at 10 43 36 AM

Looks like the step titles are using var(--pf-t--global--font--family--heading) but in Figma it is

font-family: var(--pf-t--global--font--family--body);
font-weight: var(---pf-t--global--font--weight--body--bold);
font-size: var(--pf-t--global--font--size--body--large);
github-actions[bot] commented 2 weeks ago

:tada: This PR is included in version 6.0.0-alpha.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: