patternfly / patternfly-react-seed

A PatternFly seed for React web applications
http://patternfly-react-seed.surge.sh/
MIT License
89 stars 251 forks source link

Fully built out v6 demo #209

Open evwilkin opened 9 months ago

evwilkin commented 9 months ago

Towards #202

This PR adds the following items to the seed app for the V6 demo:

https://pf6-alpha2-demo.surge.sh/

andrew-ronaldson commented 9 months ago

Noticed these issues below: The Events card on the Dashboard screen gets cut off. image

On the same screen this utility classes don't change with dark theme image

Lastly, there is an inline style on the spans. I think this should be using var(--pf-t--global--text--color--subtle)

Screenshot 2024-02-22 at 4 16 31 PM
evwilkin commented 8 months ago

@andrew-ronaldson thanks for the feedback, connected with @mcoker (added as reviewer) for suggestions on fixes and fixed the overflowing grid item && update the incorrect text colors (note - now using bold tag rather than another color per suggestion).

evwilkin commented 8 months ago

Thanks @mcoker, just FYI I went back and made those updates based on your suggestions 👍 @nicolethoen @andrew-ronaldson this demo PR should be in a good place now after feedback & fixes. The one outstanding obvious bug is the chart colors in dark theme, which I believe is yet to be updated for V6 so is as expected.

nicolethoen commented 8 months ago

This just needs to be updated to the latest alphas as soon as the official alpha versions have been announced

andrew-ronaldson commented 6 months ago
Screenshot 2024-05-21 at 12 46 35 PM

Thanks for the updates. Seeing this blue bordered section on the page now.

andrew-ronaldson commented 5 months ago

That odd border still appears. Looks like it is from a :visible-focus on main 🤷‍♂️ . Since the labels in the demo are indicating a status we should use p-m-danger/warning/success etc. instead of pf-m-red/green/orange etc.

Screenshot 2024-06-27 at 9 12 58 AM
nicolethoen commented 5 months ago

Latest surge preview with alpha2 versions: https://pf6-alpha2-demo.surge.sh/