patternfly / patternfly-react

A set of React components for the PatternFly project.
https://react-staging.patternfly.org/
MIT License
771 stars 350 forks source link

FileUpload - Expose Dropzone Error Types #10521

Open andrewballantyne opened 3 months ago

andrewballantyne commented 3 months ago

Is this a new component or an extension of an existing one? Existing component: FileUpload

Describe the feature Hey! Is there anyway to get access to Dropzone’s ErrorCode enum in TypeScript for when it rejects a drag and drop and you want to look for a specific error?

Eg. Using the FileUpload Component & providing this prop:

dropzoneProps={{
  onDropRejected: (rejections) => {
    const error = rejections[0].errors[0];
    if (error.code === ErrorCode.FileTooLarge) {
...

Are there visuals for this feature? If applicable, please include examples for each state and for varying widths N/A

Any other information?

Exposing internals of dropzone but making it difficult to write app layers against it feels like a bug more than a feature request -- but I figured this is at min a valid feature request.

tlabaj commented 3 months ago

@andrewballantyne when do you need this feature by?

andrewballantyne commented 3 months ago

I've inspected the types and just copied the underlying value -- I'd like it before Dropzone changes their implementation / types obviously... but I guess that's up to you. The sooner you do it the sooner I can close my tech debt to convert over to the proper type 🙂

Please don't put it into the trash can by any means haha ... but I don't know the effort to expose such a type inside your world.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity.

andrewballantyne commented 1 month ago

@tlabaj is this issue no longer a plan for PF? The issue is stale as of yesterday, is this a way to prune issues that don't have strict deadlines?