Test error: Cannot find the Button's disabled attribute

[dlabrecq]

Please describe the issue

4 tests cannot find the Button's disabled attribute. This test worked with v5, but no longer works with v6.

Are there visuals for this issue? Please provide screenshots

Error 1

Error 2

Error 3

Error 4

Could you point to a branch or draft PR where this issue exists? Please provide a link to the code

Error 1

• Test https://github.com/dlabrecq/koku-ui/blob/pf-v6/src/routes/settings/costModels/costModelsDetails/dialog.test.tsx#L81
• Button https://github.com/dlabrecq/koku-ui/blob/pf-v6/src/routes/settings/costModels/costModelsDetails/utils/dialog.tsx#L24

Error 2

• Test https://github.com/dlabrecq/koku-ui/blob/pf-v6/src/routes/settings/costModels/costModel/updateRateModel.test.tsx#L275
• Button https://github.com/dlabrecq/koku-ui/blob/pf-v6/src/routes/settings/costModels/costModel/updateRateModel.tsx#L131

Error 3

• Test https://github.com/dlabrecq/koku-ui/blob/pf-v6/src/routes/settings/costModels/costModel/updateRateModel.test.tsx#L335
• Button https://github.com/dlabrecq/koku-ui/blob/pf-v6/src/routes/settings/costModels/costModel/updateRateModel.tsx#L131

Error 4

• Test https://github.com/dlabrecq/koku-ui/blob/pf-v6/src/routes/settings/costModels/costModel/updateRateModel.test.tsx#L355
• Button https://github.com/dlabrecq/koku-ui/blob/pf-v6/src/routes/settings/costModels/costModel/updateRateModel.tsx#L131

[wise-king-sullyman]

These failures are because we added a new wrapping div around the text inside of buttons in v6, and the RTL byText query is now returning that wrapper rather than the button element itself, which is where those attributes live.

I would suggest using byRole queries instead and passing a name option searching for the text value you're currently passing into the byText query, as it will return the top level button element. Also FWIW the RTL team does suggest prioritizing the use of byRole queries over byText when possible.

[dlabrecq]

Updated to use byRole