search

patternfly / patternfly-react

A set of React components for the PatternFly project.
https://react-staging.patternfly.org/
MIT License
796 stars 356 forks source link

feat(charts): import charts from @patternfly/react-charts/victory #11091

Closed dlabrecq closed 1 month ago

dlabrecq commented 1 month ago

In order to support both Victory and Apache ECharts, I'd like make Victory a peer dependency.

I would also like our imports to be: import { Chart } from '@patternfly/react-charts/victory'; import { Sankey } from '@patternfly/react-charts/echarts';

https://github.com/patternfly/patternfly-react/issues/11090

patternfly-build commented 1 month ago

Preview: https://patternfly-react-pr-11091.surge.sh

A11y report: https://patternfly-react-pr-11091-a11y.surge.sh

patternfly-build commented 1 month ago

Your changes have been released in:

Thanks for your contribution! :tada: