search

patternfly / patternfly-react

A set of React components for the PatternFly project.
https://react-staging.patternfly.org/
MIT License
796 stars 356 forks source link

fix(nav): Reverts PR #10644 that caused regression #11099

Closed tlabaj closed 1 month ago

tlabaj commented 1 month ago

What: Closes #10897

cc @dlabaj we will want to promote a patch release for this

patternfly-build commented 1 month ago

Preview: https://patternfly-react-pr-11099.surge.sh

A11y report: https://patternfly-react-pr-11099-a11y.surge.sh

martinpitt commented 3 weeks ago

@dlabaj Thanks for fixing this! As this causes us quite some trouble, asking here: The 5.4.2 release happened 4 days ago already, but https://www.npmjs.com/package/@patternfly/react-core is still stuck with 5.4.1. Did something in the release go wrong?

martinpitt commented 3 weeks ago

@dlabaj ah, 5.4.2 (and 5.4.8) are in the v5-prerelease channel, not "latest". This is confusing. Sorry for the noise!

dlabaj commented 3 weeks ago

@martinpitt Thanks for catching this will fix the release to npm now.

dlabaj commented 3 weeks ago

@martinpitt It's all set on npm now. Thanks for catching this again.