patternfly / patternfly-react

A set of React components for the PatternFly project.
https://react-staging.patternfly.org/
MIT License
796 stars 356 forks source link

TextArea - add support for disabling resize #11130

Open jenny-s51 opened 3 weeks ago

jenny-s51 commented 3 weeks ago

Is this a new component or an extension of an existing one? What is the existing component, if any? Existing, TextArea

Describe the feature A clear and concise description of the new feature. What is the expected behavior?

TextArea has resize enabled by default via resizeOrientation which is set to 'both' in defaultProps: https://github.com/patternfly/patternfly-react/blob/main/packages/react-core/src/components/TextArea/TextArea.tsx#L55

Are there visuals for this feature? If applicable, please include examples for each state and for varying widths Include screenshots or links to Marvel or other mockups.

In Kubeflow, we would like to disable the resize to match how MUI themes their text fields. Since PF has resize enabled by default, this applies the .pf-m-resize-both modifier to the pf-v6-c-form-control component which requires a CSS override. Therefore in this case we wouldn't have this modifier applied to pf-v6-c-form-control.

Current: Image

Expected: Image

Any other information? cc @mcoker @srambach opening this issue per our discussion today on applying PF breaking change best practices in Kubeflow