search

patternfly / patternfly-react

A set of React components for the PatternFly project.
https://react-staging.patternfly.org/
MIT License
796 stars 356 forks source link

fix(MenuToggle): incorrect inheritance of HTMLInputElement #11145

Closed jelly closed 3 days ago

jelly commented 2 weeks ago

MenuToggleCheckboxProps inherits from HTMLInputElement and defaultChecked is typed there as undefined | boolean, null is not a valid type.

Found by typescript's tsc in strict mode.

patternfly-build commented 2 weeks ago

Preview: https://patternfly-react-pr-11145.surge.sh

A11y report: https://patternfly-react-pr-11145-a11y.surge.sh