search

patternfly / patternfly-react

A set of React components for the PatternFly project.
https://react-staging.patternfly.org/
MIT License
798 stars 356 forks source link

CodeEditor - testing is needed for interactions with React Dropzone and the Monaco Editor #7467

Open wise-king-sullyman opened 2 years ago

wise-king-sullyman commented 2 years ago

As mentioned in #7450 the Code Editor is lacking in test coverage based on our newly determined testing guidelines.

I anticipate the most difficult part of this issue will likely be determining how we should test certain aspects surrounding the Monaco Editor and React Dropzone libraries that we use.

Monaco seems to do something that makes entering text in its editor difficult using RTL, and React Dropzone has functions (such as its open function) which I'm not sure how would be best to test.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

wise-king-sullyman commented 1 year ago

Monaco mock from ACM: https://github.com/stolostron/console/blob/main/frontend/__mocks__/react-monaco-editor.tsx Where it's used: https://github.com/stolostron/console/blob/main/frontend/src/components/SyncEditor/SyncEditor.test.tsx