search

patternfly / patternfly-react

A set of React components for the PatternFly project.
https://react-staging.patternfly.org/
MIT License
796 stars 356 forks source link

Bug - Table - Refactor Column Management with Draggable demo #7471

Open jenny-s51 opened 2 years ago

jenny-s51 commented 2 years ago

Describe the problem A clear and concise description of the problem. Which components are affected?

@jenny-s51 This looks great, but there seems to be a bug with column reordering via drag & drop. If I reorder columns and then click Save, upon returning to the table, it's empty.

Originally posted by @mcarrano in https://github.com/patternfly/patternfly-react/pull/7446#pullrequestreview-986229584

@mcarrano noticed this bug upon review of #7446 ... this bug already existed in the column management draggable demo. Looks like we're using DataList's deprecated onDrag API here, along with the deprecated itemOrder prop.

In order to fix this bug, we need to refactor this demo to use DragDrop with DataList here.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.