patternfly / patternfly-react

A set of React components for the PatternFly project.
https://react-staging.patternfly.org/
MIT License
794 stars 357 forks source link

Bug - Skip to content - focus remains at top of page in demos #7554

Open thatblindgeye opened 2 years ago

thatblindgeye commented 2 years ago

Describe the problem Followup based on comment https://github.com/patternfly/patternfly-react/pull/7520#issuecomment-1154088525

The skip to content component has a bug in demos where when you click it, focus remains at the top of the page/the page does not scroll to the main content.

How do you reproduce the problem?

  1. Go to skip to content React demo
  2. Press Tab to place focus on the Skip to content button, press Enter, then press Tab again. Notice that focus goes back to the skip button, and the page did not scroll to the main content.
    • If you click anywhere on the page first then follow the steps above, the page does scroll to the main content, but focus still remains at the top of the page when pressing Tab again
  3. Go to bulk select table demo and repeat Step 2, and notice the same behavior.

Expected behavior The skip to content in React demos should have the same behavior as seen in the skip to content HTML demo

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

thatblindgeye commented 1 year ago

For additional context, this isn't a bug with only Skip To Content demo(s). Testing a full screen Page demo, clicking the SkipToContent with keyboard and then pressing the Tab key, the SkipToContent button receives focus again instead of the next focusable element within the "main content".

stale[bot] commented 11 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 9 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity.