patternfly / patternfly-react

A set of React components for the PatternFly project.
https://react-staging.patternfly.org/
MIT License
795 stars 357 forks source link

Docs: open issues & questions #7690

Open kmcfaul opened 2 years ago

kmcfaul commented 2 years ago

Capturing some questions and things to decide on regarding documentation to improve consistency.

General documentation:

Example-related:

kmcfaul commented 2 years ago

@tlabaj @mcarrano

mcarrano commented 2 years ago

@kmcfaul thanks for compiling this list. It's great feedback! We'll just need to figure out how to address these issues.

cc @wolfeallison @edonehoo

mcarrano commented 2 years ago

@wolfeallison @edonehoo Can you take a look through this and let us know what changes make sense and we'll try to start to get these in the queue.

edonehoo commented 2 years ago

@mcarrano talked to @wolfeallison and neither of us has complaints about these ideas. They all generally make sense and would be nice changes. There are a few points where we are missing additional context (re: keyboardhandler/popper, data sets data). Additionally, a handful of these seem like a best-practice decision needs to be made, and then everything should be updated to match for consistency, but I'm not sure who all should be part of the conversation to decide what the standard should be (re terminology for "basic" examples, flag modifier elements).

and a couple of thoughts on specific questions:

mcarrano commented 2 years ago

Additionally, a handful of these seem like a best-practice decision needs to be made, and then everything should be updated to match for consistency, but I'm not sure who all should be part of the conversation to decide what the standard should be (re terminology for "basic" examples, flag modifier elements).

Good question @edonehoo . I'm willing to accept a consensus opinion between content and development. If that's hard to get to, we can do something more scientific to test certain words. But that ultimately makes reaching a decision more complex. My two cents is that "default" has a very specific meaning so we should be careful to use that term unless there truly is a default option.

edonehoo commented 2 years ago

I would agree that "default" sounds more specific and suggestive. I lean towards "basic" personally, but there's nothing necessarily scientific behind that.