patternfly / patternfly-react

A set of React components for the PatternFly project.
https://react-staging.patternfly.org/
MIT License
794 stars 357 forks source link

PF4 Progress Bar: Need a unique property for percentage label #784

Closed dlabrecq closed 5 years ago

dlabrecq commented 6 years ago

The Progress component uses the same value property for both the progress bar and label shown in the upper right corner. The Koku UI needs to use a custom label as shown below.

screen shot 2018-10-16 at 12 49 51 pm

Ideally, the percent value and percent label should be two properties. Providing another property would allow me to customize the text shown in the Koku dashboard, while providing a more precise percent value (e.g., 82.94345491971737) if needed for the bar.

Note that I attempted to use the valueText property, but that appears to be used for aria-valuetext. IMO, that property name should also be prefixed with "aria", similar to alert's aria-label, to avoid confusion.

tlabaj commented 5 years ago

closed by #822