patternfly / patternfly-react

A set of React components for the PatternFly project.
https://react-staging.patternfly.org/
MIT License
760 stars 349 forks source link

Bug - [Tabs] - [Vertical Tabs show content below tablist instead of beside] #9869

Open carlosthe19916 opened 7 months ago

carlosthe19916 commented 7 months ago

Describe the problem When using vertical tabs, the content is rendered below the tablist. This looks a bit strange, especially when using boxed tabs.

How do you reproduce the problem? This behavior is shown on the Patternfly website: https://www.patternfly.org/components/tabs#vertical-tabs: 288537127-536b0c86-003d-47a4-9b49-18848fece0a4

Note that the tablist fills the entire width of the demo.

So you can use the code from that example

Expected behavior The content is displayed to the right of the tablist, as the design (especially if the tabs are boxed) indicates.

I could sort of replicate what I want by wrapping both the tablist and the content in a flexbox.

<div class="pf-v5-c-tabs pf-m-vertical pf-m-box">
  <div style="display: flex;">
    <ul class="pf-v5-c-tabs__list">...</ul>
    <section class="pf-v5-c-tab-content">Users</section>
  </div>
</div>

yields:

288542503-b60707b4-729b-41ef-824f-a785343c2e3a

Is this issue blocking you? The current workaround is to use detached tabs and place the tabs and the content in a grid and manually specifying how large each side should be.

Screenshots If applicable, add screenshots to help explain the issue.

What is your environment?

What is your product and what release date are you targeting?

OS: Arch Linux Browser: Firefox

This is a copy of the original issue https://github.com/patternfly/patternfly/issues/6117 and I moved here since I believe it fits more the ReactJS library rather than the Patternfly repo itself.

tlabaj commented 5 months ago

cc @andrew-ronaldson

wise-king-sullyman commented 5 months ago

Thanks for making this issue!

The PF leads believe this is operating as intended from a React standpoint, but that we should create a demo of vertical tabs in a sidebar once https://github.com/patternfly/patternfly/issues/6117 and any associated followup work is complete.

stale[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] commented 2 months ago

false