patternfly / pf-codemods

Codemods for upgrading from react-core@4.x.x to react-core@5.x.x. Uses eslint.
10 stars 17 forks source link

Issues encountered during early beta testing #749

Closed nicolethoen closed 5 days ago

nicolethoen commented 2 weeks ago

per this slack thread

We should check that the codemods all work as expected or at least output some guidance for these situations.

Having some trouble with a few react-core components; TextListVariants, TextListItemVariants, EmptyStateHeader, and EmptyStateIcon. Screenshot 2024-08-26 at 3 28 58 PM Screenshot 2024-08-26 at 3 24 31 PM

ToolbarItem doesn't like serach-filter as a variant. And ToolbarContent complains about bulk-select Screenshot 2024-08-26 at 3 30 18 PM Screenshot 2024-08-26 at 3 32 11 PM

thatblindgeye commented 2 weeks ago

FYI for the Toolbar updates, made in this PR in React: https://github.com/patternfly/patternfly-react/pull/10042

wise-king-sullyman commented 2 weeks ago

The EmptyState changes do at least throw errors. It can't autofix because the EmptyStateHeader in use there doesn't have titleText or children.

thatblindgeye commented 1 week ago

Leaving this open for now in case we decide to try providing an autofix for EmptyState when there's no titleText or children to use in the current autofix. Otherwise all other tasks are complete.

thatblindgeye commented 5 days ago

Opened a separate issue for EmptyState, closing this issue as all other tasks are completed