patternfly / react-component-groups

MIT License
8 stars 22 forks source link

RHCLOUD-34195 Updates to Ansible logo #312

Closed aferd closed 1 month ago

aferd commented 1 month ago

closes #221 https://issues.redhat.com/browse/RHCLOUD-34195

patternfly-build commented 1 month ago

Preview: https://react-component-groups-pr-component-groups-312.surge.sh

A11y report: https://react-component-groups-pr-component-groups-312-a11y.surge.sh

aferd commented 1 month ago

@kaylachumley

fhlavac commented 1 month ago

@aferd as mentioned in the JIRA, the Ansible component changes should be part of the v6 release, not v5. Can you please open the PR against the v6 branch?

fhlavac commented 1 month ago

@kaylachumley do we want an unsupported state for the new variant as well? In the current state the unsupported has no effect which is a bit weird

fhlavac commented 1 month ago

Just a few comments, overall it looks great! 🙂 Can you please also update the test cases when you are done? Thank you

kaylachumley commented 1 month ago

Hey @fhlavac Do you suggest we keep or remove the unsupported state? If we keep it then it'll need to pf-t--global--icon--color--disabled applied to the icon

Also it looks like the redhat AAP logo needs to be added in still

aferd commented 1 month ago

Hey @fhlavac Do you suggest we keep or remove the unsupported state? If we keep it then it'll need to pf-t--global--icon--color--disabled applied to the icon

Also it looks like the redhat AAP logo needs to be added in still

I forgot to update the example file, it should be there now.

fhlavac commented 1 month ago

 Hey @fhlavac Do you suggest we keep or remove the unsupported state? If we keep it then it'll need to pf-t--global--icon--color--disabled applied to the icon

I just suggested making the unsupported state available for both icons, now it is available only for the standalone Ansible, not Red Hat one.

fhlavac commented 1 month ago

@kaylachumley do we have any update on how/if to change the RHAP disabled state colors?

fhlavac commented 1 month ago

@aferd from what @kaylachumley found out it looks like there will be no RHAAP unsupported state for now, so we should be good.

fhlavac commented 1 month ago

@aferd I've resolved the conflicts, just we may need the snapshots to be updated