Closed aferd closed 1 month ago
@kaylachumley
@aferd as mentioned in the JIRA, the Ansible component changes should be part of the v6 release, not v5. Can you please open the PR against the v6 branch?
@kaylachumley do we want an unsupported state for the new variant as well? In the current state the unsupported
has no effect which is a bit weird
Just a few comments, overall it looks great! 🙂 Can you please also update the test cases when you are done? Thank you
Hey @fhlavac Do you suggest we keep or remove the unsupported state? If we keep it then it'll need to pf-t--global--icon--color--disabled applied to the icon
Also it looks like the redhat AAP logo needs to be added in still
Hey @fhlavac Do you suggest we keep or remove the unsupported state? If we keep it then it'll need to pf-t--global--icon--color--disabled applied to the icon
Also it looks like the redhat AAP logo needs to be added in still
I forgot to update the example file, it should be there now.
 Hey @fhlavac Do you suggest we keep or remove the unsupported state? If we keep it then it'll need to pf-t--global--icon--color--disabled applied to the icon
I just suggested making the unsupported state available for both icons, now it is available only for the standalone Ansible, not Red Hat one.
@kaylachumley do we have any update on how/if to change the RHAP disabled state colors?
@aferd from what @kaylachumley found out it looks like there will be no RHAAP unsupported state for now, so we should be good.
@aferd I've resolved the conflicts, just we may need the snapshots to be updated
closes #221 https://issues.redhat.com/browse/RHCLOUD-34195