patternfly / react-log-viewer

MIT License
17 stars 14 forks source link

Could log viewer's full screen mode be full window mode instead? #24

Open mattreid opened 1 year ago

mattreid commented 1 year ago

The OpenShift log viewer and now this log viewer both offer an expand feature, which uses the browser full screen mode to increase the size and offer more screen real estate. This is really frustrating as someone who always has multiple tabs and multiple windows open, I never want that on a big monitor. On Mac there's an animation to open it, and again to close it, and I have to close it to go do anything other than look at the log. We use the OpenShift based log viewer in RHTAP today (part of HAC) in a variety of spots (modal, side panel, tab, etc), and in cases where I want it to be bigger and not have to scroll vertically or horizontally as much, I just want it to be bigger within my window, so I can keep my normal workflow. I'm assuming we may move over to this new implementation at some point, so if there's something we can do here to change that behavior, or offer another viewing mode alongside fullscreen that does this, that gives us another reason to move when its ready.

Is this something you'd consider?

DaoDaoNoCode commented 1 year ago

This is definitely a good suggestion. cc @jessiehuff