search

patternfly / react-log-viewer

MIT License
22 stars 14 forks source link

Fix whitespace in log viewer search examples #5

Open mcoker opened 3 years ago

mcoker commented 3 years ago

There is a leading space before the search match that shouldn't be there.

Screen Shot 2021-06-18 at 1 23 49 PM
stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 30 days if no further activity occurs.

mcoker commented 3 years ago

@mcarrano can we add this to an upcoming milestone? It's just a problem with our workspace examples, so it's low priority.

mcarrano commented 3 years ago

@nicolethoen @evwilkin How should we handle extension issues moving forward. Since log viewer is now a UXD extension, I was assuming we would not track issues in our PF milestones. But what should we do with this and other log viewer issues?

nicolethoen commented 3 years ago

For now, I think that Juntao will create issues and implement fixes with aid from PF. He is sort of modifying it and building on it as he needs for the OpenShift implementation. As he makes changes we can review the PRs and I can tag you for design reviews when appropriate. Once he moves on we will have to discuss ongoing maintenance going forward

nicolethoen commented 3 years ago

But if there are simple tweaks that people want to make in their spare time, I'd say - as Zack often does - feel free to open PRs to make small changes as you have desire and are able :)

mcarrano commented 3 years ago

That's all fine. But I guess my question remains whether we will add these issues to our PatternFly milestones.