Design review / updates for react log viewer

patternfly / react-log-viewer

MIT License

17 stars 14 forks source link

Design review / updates for react log viewer #63

Closed dlabaj closed 3 months ago

dlabaj commented 4 months ago

The latest version of the first alpha was merged in this PR https://github.com/patternfly/react-log-viewer/pull/60 It does require additional design review.

[x] Alpha has been reviewed by design
[ ] Updates have been made to the UI per design review
[ ] Code reivew and tested

Link to surge site to review:

Surge preview

andrew-ronaldson commented 4 months ago

Just one small updates. The search input in the demo looks like it is still PF 5. When I inspected everything still referenced v5 but that's the only one that didn't seem to be visually updated. Screenshot 2024-04-25 at 10 22 28 AM

andrew-ronaldson commented 4 months ago

Screenshot 2024-04-25 at 10 33 14 AM Sorry one other thing is the pause button should have a .pf-m-start class to add the xs spacer between the icon and the text in the button.

nicolethoen commented 3 months ago

Closed by #64