patternfly / react-topology

MIT License
9 stars 18 forks source link

Bug: Task Nodes - missing status icons #147

Closed jenny-s51 closed 5 months ago

jenny-s51 commented 5 months ago

Describe the problem A clear and concise description of the problem. Which components are affected?

For pipeline task nodes, only the error and warning status icons currently render in the nodes when topology view is zoomed out.

How do you reproduce the problem? Provide steps to reproduce. A codesandbox demonstrating the problem is appreciated.

Screenshot 2024-02-16 at 3 19 59 PM

Expected behavior A clear and concise description of the expected behavior.

Expected behavior is that all status icons still render when the details level is reduced after zooming out. See initial PR screenshots in https://github.com/patternfly/react-topology/pull/31#issue-1662533899

What is your product and what release date are you targeting? RHOAI v2 pipelines

jeff-phillips-18 commented 5 months ago

These defaults are intentional: https://github.com/patternfly/react-topology/blob/main/packages/module/src/pipelines/components/nodes/TaskNode.tsx#L125

Applications that want to show other status can override the default. The idea behind the default is to only show status that would normally require attention making them easier for users to find at low scales.

@andrew-ronaldson Please feel free to comment and reopen if the design has changed.