search

patternfly / react-topology

MIT License
9 stars 18 forks source link

Bug: nameLabelClass declared as a prop but is not used #151

Closed jenny-s51 closed 4 months ago

jenny-s51 commented 4 months ago

Describe the problem A clear and concise description of the problem. Which components are affected?

See https://github.com/patternfly/react-topology/blob/bed1c18ab7c4d1f47278bb3cc11ac8253c613270/packages/module/src/pipelines/components/nodes/TaskNode.tsx#L42 nameLabelClass is declared as prop but missing from nameLabel attributes.

It is also declared in https://github.com/patternfly/react-topology/blob/bed1c18ab7c4d1f47278bb3cc11ac8253c613270/packages/module/src/pipelines/decorators/WhenDecorator.tsx#L29 and can be removed as there is no nameLabel component it corresponds to.

How do you reproduce the problem?

Try setting nameLabelClass on a TaskNode. Custom classname is not added.

Expected behavior

Classname is visible.

What is your product and what release date are you targeting? RHOAI pipelines v2

github-actions[bot] commented 4 months ago

:tada: This issue has been resolved in version 5.3.0-prerelease.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: