patternfly / react-topology

MIT License
9 stars 18 forks source link

feat(pipelines): Add pipeline groups layout #157

Closed jeff-phillips-18 closed 4 months ago

jeff-phillips-18 commented 4 months ago

What

Closes #155 Closes RHOAIENG-4186

Description

Adds a DagreGroupsLayout and PipelineDagreGroupsLayout which treats each group as its own layout. Groups are connected to tasks or other groups.

Type of change

Screen shots / Gifs for design review

Horizontal

image

Vertical

image

/cc @andrewballantyne

Surge

https://pipeline-groups.surge.sh/

andrewballantyne commented 4 months ago

Question: You have a colour shift for the internal groups -- does this mean there are only allowed one layer of groups inside groups? If not, what does it look like if another group is inside the inner group?

jeff-phillips-18 commented 4 months ago

Question: You have a colour shift for the internal groups -- does this mean there are only allowed one layer of groups inside groups? If not, what does it look like if another group is inside the inner group?

@andrewballantyne the group background alternates:

image

jeff-phillips-18 commented 4 months ago

Wondering it if would make sense to update the default label positioning to "top"

@jenny-s51 Moved them to the top for vertical layout (this is in the app code not the toolkit)

image

andrewballantyne commented 4 months ago

Design wise this lgtm -- I didn't dive into the code.

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 5.3.0-prerelease.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: