fix(pipelines): Handle collapsed groups better

jeff-phillips-18 commented 2 months ago

What

Closes #185

Description

Fixes: Collapsed pipeline groups position when they are nested two levels deep Put spacer nodes created for pipeline group layout into the groups they belong, new helper function addSpacerNodes Scaled node position and anchors for pipeline layouts Export some missing components so they don't need to be specifically imported Respect the parameter labelPosition when passed to DefaultTaskGroup

Type of change

[ ] Feature
[x] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review

patternfly-build commented 2 months ago

Preview: https://react-topology-pr-topology-186.surge.sh

jeff-phillips-18 commented 2 months ago

Wondering if we would want to pass in arrow indicators on the edges to show the runAfter tasks and better match RHOAI... WDYT?

I can add the arrows though to me the dependencies are inferred.

Upper nesting levels look awesome, though for some reason your changes aren't getting applied to the deeper levels:

The edges that look "off" are due to dependencies of nodes of one group on nodes of another group. The group layout will not consider these dependencies. I will update the data in the demo app to not have such dependencies.

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 5.4.0-prerelease.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

patternfly / react-topology