patternfly / react-topology

MIT License
8 stars 17 forks source link

Update to latest Patternfly V6 alphas #201

Closed jeff-phillips-18 closed 1 week ago

jeff-phillips-18 commented 1 month ago

What

Updates to last Patternfly V6 alpha release.

Type of change

patternfly-build commented 1 month ago

Preview: https://react-topology-pr-topology-201.surge.sh

jeff-phillips-18 commented 1 month ago

There are 2 commits here:

  1. run the v6 code mods
  2. make fixes to get close

You can look at the second commit to see where the codemods fell short.

jeff-phillips-18 commented 1 month ago

Demo app surge: https://v6-updates.surge.sh/

nicolethoen commented 4 weeks ago

@jeff-phillips-18 can I do anything to help move this along?

jeff-phillips-18 commented 2 weeks ago

@andrew-ronaldson @nicolethoen @jenny-s51 Please take another look. I think this is in good shape now.

Latest surge for Demo app: https://v6-updates.surge.sh/

Surge for Doc app: https://react-topology-pr-topology-201.surge.sh/

jeff-phillips-18 commented 1 week ago

@andrew-ronaldson @jenny-s51 Updated. PTAL.

andrew-ronaldson commented 1 week ago

Looks good. I still see the hover/selected state bug on the node labels. We can fix that in another PR.

Surge Status + hover:

Screenshot 2024-06-26 at 10 08 39 AM

Status+Selected + hover:

Screenshot 2024-06-26 at 10 04 01 AM

Figma Status + hover: Screenshot 2024-06-26 at 10 07 52 AM

Status + Selected + hover: Screenshot 2024-06-26 at 10 05 22 AM

jeff-phillips-18 commented 1 week ago

@andrew-ronaldson @jenny-s51 Updated. PTAL.

jeff-phillips-18 commented 1 week ago

Just noticing the sidebar example window isn't rendering on the docs site (all the other demos look great) https://react-topology-pr-topology-201.surge.sh/topology/sidebar.

@jenny-s51 The docs surge did not get updated. If you run locally you will see this fix.

jenny-s51 commented 1 week ago

Sounds good @jeff-phillips-18 pulling it down to take a look