patternfly / react-topology

MIT License
12 stars 19 forks source link

fix(pipelines): update running and pending icon colors #31

Closed karthikjeeyar closed 1 year ago

karthikjeeyar commented 1 year ago

Fixes: Bug - https://github.com/patternfly/react-topology/issues/12

Screenshots:

Screenshot 2023-04-11 at 7 15 10 PM Screenshot 2023-04-11 at 6 56 36 PM

Screenshot 2023-04-11 at 6 57 00 PM Screenshot 2023-04-11 at 6 57 10 PM

jeff-phillips-18 commented 1 year ago

Surge: https://topology-pr-31.surge.sh/

jeff-phillips-18 commented 1 year ago

@andrew-ronaldson @serenamarie125 Please take a look. Surge link is above.

jeff-phillips-18 commented 1 year ago

@andrew-ronaldson @mceledonia Can you please take a look at confirm these match the latest spec? I know @mceledonia was go to take a look based on contrast checker issues.

andrew-ronaldson commented 1 year ago

Here's some notes based on a conversation with @mceledonia

  1. We can consolidate the Running and inProgress tasks from the demo and use the alt-sync icon. For running we went with blue-200 and black-900 text for the default state and to bump up the contrast onSelect we matched both the icon & text to be black-900 (screenshot).
  2. The Warning states was already using the black text onSelect so we applied the same treatment for consistency and better contrast on the gold. Screen Shot 2023-04-17 at 5 41 11 PM
karthikjeeyar commented 1 year ago

Thanks @andrew-ronaldson. I have unified inprogress and running status icons and styles and updated warning selected state to be black. Please take a look

https://user-images.githubusercontent.com/9964343/232853197-959ff861-ee70-4f60-a26a-dc5ae088f403.mov

andrew-ronaldson commented 1 year ago

Thanks for this @karthikjeeyar this looks great! I forgot to mention that I don't think the pending task needs to blue icon. I think that can remain the default grey.

karthikjeeyar commented 1 year ago

For Pending Icon, I have used --pf-global--secondary-color--100. @andrew-ronaldson Let me know if you have some other color defined for pending icon.

Light Mode: default state selected state
Screenshot 2023-04-18 at 11 39 32 PM Screenshot 2023-04-18 at 11 39 47 PM
Dark mode: default state selected state
Screenshot 2023-04-18 at 11 40 01 PM Screenshot 2023-04-18 at 11 40 07 PM
andrew-ronaldson commented 1 year ago

Just thinking about this some more following @jenny-s51 screenshots. Do the pending, idle and skipped tasks need a special styling beyond the icons? I can't remember if they had unique features prior to the PF update

karthikjeeyar commented 1 year ago

Updated

Screenshot 2023-04-21 at 7 39 22 PM Screenshot 2023-04-21 at 7 39 26 PM Screenshot 2023-04-21 at 7 39 34 PM Screenshot 2023-04-21 at 7 39 40 PM

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 4.93.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 4.93.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: