Closed karthikjeeyar closed 1 year ago
@andrew-ronaldson @serenamarie125 Please take a look. Surge link is above.
@andrew-ronaldson @mceledonia Can you please take a look at confirm these match the latest spec? I know @mceledonia was go to take a look based on contrast checker issues.
Here's some notes based on a conversation with @mceledonia
Thanks @andrew-ronaldson. I have unified inprogress and running status icons and styles and updated warning selected state to be black. Please take a look
https://user-images.githubusercontent.com/9964343/232853197-959ff861-ee70-4f60-a26a-dc5ae088f403.mov
Thanks for this @karthikjeeyar this looks great! I forgot to mention that I don't think the pending task needs to blue icon. I think that can remain the default grey.
For Pending Icon, I have used --pf-global--secondary-color--100
. @andrew-ronaldson Let me know if you have some other color defined for pending icon.
Light Mode: | default state | selected state |
---|---|---|
Dark mode: | default state | selected state |
---|---|---|
Just thinking about this some more following @jenny-s51 screenshots. Do the pending, idle and skipped tasks need a special styling beyond the icons? I can't remember if they had unique features prior to the PF update
Updated
:tada: This PR is included in version 4.93.5 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
:tada: This PR is included in version 4.93.6 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Fixes: Bug - https://github.com/patternfly/react-topology/issues/12
Screenshots: