patternfly / react-topology

MIT License
12 stars 19 forks source link

chore(strictFunctionTypes): Set strictFunctionTypes #53

Closed jeff-phillips-18 closed 1 year ago

jeff-phillips-18 commented 1 year ago

What

Closes #48

Description

Sets strictFunctionTypes in tsconfg.json, updates components to take GraphElement in order to satisfy the ComponentFactory typings, and fixes issues found by setting strictFunctionTypes

Type of change

jeff-phillips-18 commented 1 year ago

Rebased

jeff-phillips-18 commented 1 year ago

@jenny-s51 Hmmm... yeah. I'll look into it

jeff-phillips-18 commented 1 year ago

@jenny-s51 Fixed. observer needs to be on the inner components.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 5.0.0-alpha.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 5.0.0-prerelease.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: