search

patternfly / react-topology

MIT License
10 stars 19 forks source link

mobx-react warning on newer versions #70

Open tomperr opened 1 year ago

tomperr commented 1 year ago

Describe the problem An import of batchingForReactDom generates a warning with newer version of mobx-react

How do you reproduce the problem? Create a new TS/JS project that depends on the last version of patternfly/react-topology, and import VisualizationSurface component. Launch the project (in dev) A warning appears in the browser's console : [mobx-react-lite] importing batchingForReactDom is no longer needed

Expected behavior No warning

Is this issue blocking you? Not really, it is just a bit dirty to keep this warning

What is your environment?

Any other information? My suggestion would be to bump mobx-react to ^7.0.0, as the import of batchingForReactDom in VisualizationSurface.tsx won't be needed, so we would be able to remove it, which will remove the warning for any accepted version of this library

lordrip commented 11 months ago

Here's a screenshot from a test execution showcasing the same warning

image