patternfly / training-scenarios

PatternFly Developer Training
https://www.patternfly.org/v4/documentation/react/overview/training
8 stars 26 forks source link

React Table: feedback from user example #197

Closed christiemolloy closed 4 years ago

christiemolloy commented 5 years ago

Step 3 # 2 not clear that you have to make them all objects

Reformatting certain blocks within the editor in regards to coding...include in structure in quick reference guide for the structure of the module

Step 3 nothing should visibly show when adding changes Need examples…

Step 5 no.2 does not explicitly use copy to editor button

Show tips for shortcuts…. (suggested enhancements)

Step 5 no.3...users are ignoring link...no hover state that link is active...what is it ..what does it do.

Step 3 &4 might need to be reversed or make a note look at step 4 to compile…

Step 6 import from React Core...most users will not know what that is……..

Step 6 hint of what it should look like in the pagination component

Step 6 extra code block...should hide within the solution area

Step 7 no.1 typo with Respectively.

Step 7 no.1 clarify what you are setting (Setters)??

Step no.2/no.3 More description on where you adding a prop to ...More context

Step 7 no.4. Find the component...set the property...like is stated in previous examples….

Step 8 no.1 does not have detailed descriptions of where to add it…

Step 8 no.2...remove brackets from variable

Step 8 no.4 clarify where to add that line..

Step 8 no.5 does not introduce the term hook (react)...should be added….

Copy to clipboard...formats properly as well copy to editor...works properly…

Swipe back causes lose focus..(Chrome issue)

Step 9 no.3..what is funtional signature...clarify that term…

Step 9 no.3...add react call back...before you pass etc...poorly explained context why we are doing this step….

Step 9 no.4...not clear...needs better explanation..of what and why you are doing this step

Step 9 no.5.reference update list..but does not show it in code blocks…

christiemolloy commented 4 years ago

closing because this has been resolved