search

patternfly / training-scenarios

PatternFly Developer Training
https://www.patternfly.org/v4/documentation/react/overview/training
8 stars 26 forks source link

Area chart changes #209

Closed christiemolloy closed 4 years ago

christiemolloy commented 5 years ago

All area chart changes, including @gheake2 changes here: https://github.com/patternfly/training-scenarios/pull/207/files

You can view the changes here: https://katacoda.com/cmolloy/courses/react-charts/area-chart

dlabrecq commented 4 years ago

Also seeing a few warnings in the browser console. Perhaps this is a setting we can change?

Screen Shot 2019-11-29 at 9 55 46 AM
christiemolloy commented 4 years ago

updated @dlabrecq

dlabrecq commented 4 years ago

I went through the tutorial again and it's looking good.

For step 6, can we also move the legendPosition before adding legendData? The legendPosition="right" doesn't change anything because that's the default. Alternatively, we could just remove it.

Also, can we please change step 1 and step 2 to use interpolation="monotoneX". We need to change all our examples to use this value per https://github.com/patternfly/patternfly-react/issues/3329

christiemolloy commented 4 years ago

Ok updated. I can't see any interpolation property in other modules should I add them in here?

dlabrecq commented 4 years ago

The interpolation property only applies to the area chart, thanks