search

patternfly / virtual-assistant

This repo contains the code for the PatternFly virtual assistant extension
MIT License
0 stars 19 forks source link

Header logo does not center when configuring header component #158

Closed asuwebdesign closed 1 month ago

asuwebdesign commented 1 month ago

When configuring the chatbot header, the logo does not remain centered.

Example: The consumer removes the menu action, and the logo shifts to the left.

Screenshot 2024-09-20 at 11 13 06 AM
rebeccaalpert commented 1 month ago

I didn't create these, but I think this is by design. Right now our header and examples are configured so the user has to pass a PatternFly Bullseye layout or similar-styled layout if they want centered behavior.

Without bullseye:

Screenshot 2024-09-20 at 4 44 30 PM

With bullseye:

Screenshot 2024-09-20 at 4 44 49 PM
asuwebdesign commented 1 month ago

Thanks for the clarification. This might have been influenced by the fullscreen version, which hasn't really finalized a good composition yet. Not anyone's fault, we just expedited through this. One thing we don't have a final design for is the model selector for overlay/dock modes.

General idea was to have a grid layout for overlay/dock modes that keeps both logo and actions in their respective columns to make it look centered but then for fullscreen we update the middle column to be left-aligned (or right-aligned for RTL) and it grows to fill that space in between.

The engineers didn't know exactly how to do the bullseye approach, so maybe some code examples or perhaps we get a little more opinionated and maybe do the work for them and they just change a prop on a component. Something I observed with them today.

rebeccaalpert commented 1 month ago

Got it. I think I'm getting a better sense of what you're seeing after pulling down the Ansible repo. It looks like they're using a Bullseye, but the Split layout isn't letting it take up the full space it needs.

Let's plan on adjusting the way the header's built. We need to do a combination of bug fixes and getting features out the door. I'm going to focus on feature development next sprint, but I'll try to pull in bugs where I can.

rebeccaalpert commented 1 month ago

This should be all set!