search

patterns-ai-core / langchainrb

Build LLM-powered applications in Ruby
https://rubydoc.info/gems/langchainrb
MIT License
1.18k stars 156 forks source link

fix: GoogleGemini generation_config param #665

Closed mazenkhalil closed 6 days ago

mazenkhalil commented 2 weeks ago

Fixes #648

andreibondarev commented 2 weeks ago

@mazenkhalil Do you think you could add a quick spec?

mazenkhalil commented 2 weeks ago

@mazenkhalil Do you think you could add a quick spec?

I have synced the whole implementation with GeminiAPI & and I have added the tests

mazenkhalil commented 2 weeks ago

@andreibondarev Any update here?

mazenkhalil commented 1 week ago

@andreibondarev Is there anything I can do to speed up the review process here?

andreibondarev commented 1 week ago

@andreibondarev Is there anything I can do to speed up the review process here?

A few comments, otherwise -- let's ship it!

andreibondarev commented 6 days ago

@mazenkhalil Thank you! Merged.