search

patterns-ai-core / langchainrb

Build LLM-powered applications in Ruby
https://rubydoc.info/gems/langchainrb
MIT License
1.18k stars 156 forks source link

Update comments for hnswlib `similarity_search` and `similarity_search_by_vector` methods #669

Closed yash-learner closed 1 week ago

yash-learner commented 1 week ago

Closes #668

andreibondarev commented 1 week ago

@yash-learner Thank you for the PR, nice find! Are you actually using HNSW lib? How's it working out for you?

yash-learner commented 1 week ago

@yash-learner Thank you for the PR, nice find!

@andreibondarev Thank you for merging the PR! and the amazing work you are doing.

Are you actually using HNSW lib? How's it working out for you?

I just started learning and playing around with GenAI during weekends when I find some time. I decided to go with an in-memory vector store HNSW lib as it is simple to start working with, compared to hosted vector stores. During this process, I found the issue with the documentation. It has been a great learning experience so far.