search

patterns-group / code-patterns

Code Patterns: lots of reusable goodies for your .NET project
tribesoftware.org/code-patterns/
BSD 2-Clause "Simplified" License
9 stars 9 forks source link

Updated Common.Logging to 3.0 #169

Closed jarroda closed 9 years ago

jarroda commented 9 years ago

I have upgraded Common.Logging to 3.0. Older version of Common.Logging appear to be incompatible, so I am unable to use code-patterns in a project which is already using Common.Logging 3.0+.

jbatte47 commented 9 years ago

Have you tried using assembly redirects? Assuming you have and Common.Logging has made a backward-incompatible change, I'll approve this, but it needs to go to the right branch to roll out as a release. Do me a favor and point to TheTribe:next with this and I'll approve it; if you don't get to it by Sunday and I can confirm this is a reference-level issue, I'll try to knock it out for you.

jarroda commented 9 years ago

I did try using an assembly redirect up to 3.0, but apparently 3.0 is not reverse compatible due to the introduction of PCL support. https://github.com/net-commons/common-logging/issues/74#issuecomment-69961417

I will try to update this PR to the correct branch as soon as I get a chance.

On Fri, Feb 6, 2015 at 9:18 PM, John Batte notifications@github.com wrote:

Have you tried using assembly redirects https://msdn.microsoft.com/en-us/library/7wd6ex19%28v=vs.110%29.aspx? Assuming you have and Common.Logging has made a backward-incompatible change, I'll approve this, but it needs to go to the right branch to roll out as a release. Do me a favor and point to TheTribe:next with this and I'll approve it; if you don't get to it by Sunday and I can confirm this is a reference-level issue, I'll try to knock it out for you.

— Reply to this email directly or view it on GitHub https://github.com/TheTribe/code-patterns/pull/169#issuecomment-73347526 .