pattex / jekyll-tagging

Jekyll plugin to automatically generate a tag cloud and tag pages.
385 stars 76 forks source link

Only one tag page generated from tags that differ only in capitalization #25

Open efung opened 10 years ago

efung commented 10 years ago

I have a post tagged with, say, "Milk" and another tagged with "milk". These are treated as distinct tags within Jekyll, as I see both when iterating through site.tags and my tag list page.

However, no tag page is generated for the capitalized one. That is, the page <site>/tag/milk/index.html is generated, but NOT <site>/tag/Milk/index.html.

Something to do with case sensitivity on the underlying file system? (I'm on a Mac, FWIW).

For my particular usage, I don't need two separate tag pages, I'd be happy to coalesce both of them, preferably without having to edit all the posts.

pattex commented 10 years ago

You are right, that should be addressed. Thanks.

nybblr commented 10 years ago

Facing this issue from a slightly different angle: I need to display tags with their "pretty" name, but generate pages with a slugged URL (e.g. parameterize) for nicer URLs. This would also prevent the capitalization issue.

This seems like an underlying issue with Jekyll — do you know of any easy way to inject functionality into Jekyll's site.tags and post.tags without monkeypatching the methods? Jekyll doesn't seem to provide a nice injection mechanism =/ or is this something that could/should be handled in a plugin like jekyll-tagging?

nhoizey commented 9 years ago

@nybblr URLs are now "slugged": https://github.com/pattex/jekyll-tagging/commit/11eb1f9ff3426c270e5f5a55b1a2e8f028aea329

There is now one single page, but the tags cloud still shows the upper and lower-case variants, which leads to another issue: #38