search

pattex / jekyll-tagging

Jekyll plugin to automatically generate a tag cloud and tag pages.
385 stars 76 forks source link

Call to_s on the tags before processing #46

Closed queirozfcom closed 8 years ago

queirozfcom commented 8 years ago

Because some tags may be things like number or reserved words, and then you'll get undefined_method remove_diacritics for Float, and so on. Calling to_s before fixed it for me.

amcewen commented 8 years ago

I hit this problem too, and @queirozfcom's fix seems to do the trick (thanks @queirozfcom!)

queirozfcom commented 8 years ago

Well until it's merged or otherwise fixed, I'm using gem 'jekyll-tagging', :git => 'https://github.com/queirozfcom/jekyll-tagging.git' in my Gemfile @amcewen

amcewen commented 8 years ago

@queirozfcom Ah, hadn't realised you could do that with gem - I'm patching it afterwards at the minute. Thanks!

nhoizey commented 8 years ago

Had the same issue, any way to accelerate Pull Request merging?

pattex commented 8 years ago

Hey, I only merged ed09d3d7b6590d242fe8b57948881567cb000f0e

Thanks a lot and greetings pattex - the worst open source maintainer of the galaxy

nhoizey commented 8 years ago

Thanks @pattex !