search

paturikarthik / pe

0 stars 0 forks source link

Unclear Error Message #3

Open paturikarthik opened 2 months ago

paturikarthik commented 2 months ago

image.png The error message indicates that "Unable to detect integer! Ensure that there are no extra / illegal characters other than numbers Ensure that integer is a positive integer no larger than 2147483647" but does not say which field the error is for

nus-pe-bot commented 2 months ago

Team's Response

Hi tester, as the coder responsible for the parser, I totally agree with you that the error message can be more specific to the kinds of fields. However, I have assigned a lower severity to Low. The reasons are below.

The new command takes in only integer in the quantity field; the allowed format for price is 1, 0.1 and 1.23. Logically, the invalid field will be quantity. For other commands that takes in invalid PID and quantity, an error will prompt for the invalid PID first. At the same time, quantity is unlikely to be in decimal points, hence our choice of integer for quantity field.

For users who might be first time users, there are help new and user guide where they can clarify where the integer should go to.

Hope these clarifies. Thanks!

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Glad to hear that we both agree on this issue! However, I still believe this is a medium severity issue as the error message does not give the users an indication on what went wrong and leaves them to figure it out on their own. By not being clear in the error message, the team has left the error tracing to the user. As such, the inconvenience caused is still substantial.