paturikarthik / pe

0 stars 0 forks source link

Uninformative Error Message for invalid quantity in text file #5

Open paturikarthik opened 2 months ago

paturikarthik commented 2 months ago

After editing the inventory file to include quantity as 100.5, the program correctly identifies that there is an error. However, the error message is generic and does not identify the error which was made.

image.png

The following is a good example of the error message when duplicate entries were made!

image.png

nus-pe-bot commented 2 months ago

Team's Response

Hi there, thank you for the report.

Indeed, we do appreciate the fact that you have pointed out that our error messages could be more informative. However, since you were confident enough to edit the data file, as stated in the warning message image below and in our User Guide website link here, it is assumed that you would know what would be the errorneous data input in the file, since you were the one making the raw edit of the file. Despite that, I would still accept the fact that our error message should be more informative.

image.png

However, this report should not be of MEDIUM as this is a rare situation that the user would edit the data in a way that the quantity would be of a float number, and not an integer. Additionally, as we had warned the user to make a backup of the file before editing, it would only cause a small inconvenience to a small group of users, like yourselves.

Despite this, thank you for the report.

Best Regards, StockPal Team

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Given that the product does not work anymore after facing the error (the app auto exits), there is a possibility that this might be a severity.high as well.

However, since this error only occurs occasionally and users can fall back on backup files as you mentioned, a fairer assessment would be severity.medium. As such, I believe that it is harsh for the team to choose severity.low as this bug is likely to be between severity.medium and severity.high.