patverga / bran

Full abstract relation extraction from biological texts with bi-affine relation attention networks
Apache License 2.0
128 stars 33 forks source link

Why not outputs += inputs ? #5

Open speedcell4 opened 6 years ago

speedcell4 commented 6 years ago

https://github.com/patverga/bran/blob/3bdb65fbd37961c640ecc1e31696c09e4d89257b/src/models/transformer.py#L269

patverga commented 6 years ago

This should definitely be outputs += inputs. This is a bug that will need to be fixed, thanks for catching.

speedcell4 commented 6 years ago

if you re-run your program, could you please let me know the new results? thx